Re: [PATCH]: Re: qla1280.c broken on SGI visws, PCI coherency problem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michael Reed wrote:

James Bottomley wrote:
On Tue, 2005-12-13 at 07:22 -0600, Michael Reed wrote:
I believe the biggest issue with VISWS is that it appears to need
mmiowb() and we likely don't know how to implement it.  Hence, for
that platform, it would make sense to replace the mmiowb() with a
posting read.
Well, there's an easy way to tell ... the reason for the mmiowb in the
qla1280 driver is supposed to be an SMP race, according to the
description, so if it fails on UP as well there's something else going
on here ...

I'm still suspicious because the mmiowb() in this driver replaced a
posted write flush instruction, which altered the behaviour of the
driver.  The qla1280 is just rare enough that it might have taken this
long to notice ...

Yup.  But.... keep in mind that the failing platform is the SGI
VISWS, the child of a PC and an O2.  I'd be much more suspicious
if it failed on a generic PC.  (It also works fine on SGI Altix,
a platform which has implemented mmiowb().)

Perhaps Mr. Joosten can confirm his failing case with the UP kernel?

OK, I'm currently doing this, though with a Fedora Core3 kernel (2.6.12-1.1381-FC3) UP and SMP, running it with some ooold filesystem benchmark on a similarly old PIII 500MHz board. What else is possible is an Intel dual PII (450MHz) server board (N440BX) , a dual PIII(730MHz) workstation and a very recent one with hyperthreading PIV. I'm currently using a distributed kernel with modules, because this version still has the mmiowb() in place (I hope!) . There might be a timing issue (the faults happend somehow earlier once the board and the VisWS got warmer), but I hope that the other platforms will show a little difference... Well, the PIII board with both a 550 and a 800 MHz proc showed no difference, the driver just *works*, no failure in 20 runs. It looks like the problem only shows up in the VISWS. Perhaps I try it again putting the QLA1080 in the 32bit slot, which is apparently not controlled by the Lithium, but rather a plain PIIX chip. And perhaps some other platform and chipset.

Regards, Michael



-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux