Hi Ivaylo, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Ivaylo-Ivanov/dt-bindings-phy-rename-qcom-snps-eusb2-phy-binding-to-snps-eusb2-phy/20250223-202709 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20250223122227.725233-5-ivo.ivanov.ivanov1%40gmail.com patch subject: [PATCH v2 4/8] phy: move phy-qcom-snps-eusb2 out of its vendor sub-directory config: sh-randconfig-r073-20250307 (https://download.01.org/0day-ci/archive/20250307/202503072305.Osodtcnk-lkp@xxxxxxxxx/config) compiler: sh4-linux-gcc (GCC) 14.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202503072305.Osodtcnk-lkp@xxxxxxxxx/ smatch warnings: drivers/phy/phy-snps-eusb2.c:452 snps_eusb2_hsphy_probe() warn: passing zero to 'PTR_ERR' vim +/PTR_ERR +452 drivers/phy/phy-snps-eusb2.c 15a1981f608b0f Ivaylo Ivanov 2025-02-23 399 static int snps_eusb2_hsphy_probe(struct platform_device *pdev) 15a1981f608b0f Ivaylo Ivanov 2025-02-23 400 { 15a1981f608b0f Ivaylo Ivanov 2025-02-23 401 struct device *dev = &pdev->dev; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 402 struct device_node *np = dev->of_node; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 403 struct snps_eusb2_hsphy *phy; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 404 struct phy_provider *phy_provider; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 405 struct phy *generic_phy; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 406 const struct snps_eusb2_phy_drvdata *drv_data; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 407 int ret, i; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 408 int num; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 409 15a1981f608b0f Ivaylo Ivanov 2025-02-23 410 phy = devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 411 if (!phy) 15a1981f608b0f Ivaylo Ivanov 2025-02-23 412 return -ENOMEM; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 413 15a1981f608b0f Ivaylo Ivanov 2025-02-23 414 drv_data = of_device_get_match_data(dev); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 415 if (!drv_data) 15a1981f608b0f Ivaylo Ivanov 2025-02-23 416 return -EINVAL; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 417 phy->data = drv_data; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 418 15a1981f608b0f Ivaylo Ivanov 2025-02-23 419 phy->base = devm_platform_ioremap_resource(pdev, 0); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 420 if (IS_ERR(phy->base)) 15a1981f608b0f Ivaylo Ivanov 2025-02-23 421 return PTR_ERR(phy->base); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 422 15a1981f608b0f Ivaylo Ivanov 2025-02-23 423 phy->phy_reset = devm_reset_control_get_exclusive(dev, NULL); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 424 if (IS_ERR(phy->phy_reset)) 15a1981f608b0f Ivaylo Ivanov 2025-02-23 425 return PTR_ERR(phy->phy_reset); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 426 15a1981f608b0f Ivaylo Ivanov 2025-02-23 427 phy->clks = devm_kcalloc(dev, 15a1981f608b0f Ivaylo Ivanov 2025-02-23 428 phy->data->num_clks, 15a1981f608b0f Ivaylo Ivanov 2025-02-23 429 sizeof(*phy->clks), 15a1981f608b0f Ivaylo Ivanov 2025-02-23 430 GFP_KERNEL); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 431 if (!phy->clks) 15a1981f608b0f Ivaylo Ivanov 2025-02-23 432 return -ENOMEM; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 433 15a1981f608b0f Ivaylo Ivanov 2025-02-23 434 for (int i = 0; i < phy->data->num_clks; ++i) 15a1981f608b0f Ivaylo Ivanov 2025-02-23 435 phy->clks[i].id = phy->data->clk_names[i]; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 436 15a1981f608b0f Ivaylo Ivanov 2025-02-23 437 ret = devm_clk_bulk_get(dev, phy->data->num_clks, 15a1981f608b0f Ivaylo Ivanov 2025-02-23 438 phy->clks); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 439 if (ret) 15a1981f608b0f Ivaylo Ivanov 2025-02-23 440 return dev_err_probe(dev, ret, 15a1981f608b0f Ivaylo Ivanov 2025-02-23 441 "failed to get phy clock(s)\n"); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 442 15a1981f608b0f Ivaylo Ivanov 2025-02-23 443 phy->ref_clk = NULL; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 444 for (int i = 0; i < phy->data->num_clks; ++i) { 15a1981f608b0f Ivaylo Ivanov 2025-02-23 445 if (!strcmp(phy->clks[i].id, "ref")) { 15a1981f608b0f Ivaylo Ivanov 2025-02-23 446 phy->ref_clk = phy->clks[i].clk; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 447 break; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 448 } 15a1981f608b0f Ivaylo Ivanov 2025-02-23 449 } 15a1981f608b0f Ivaylo Ivanov 2025-02-23 450 15a1981f608b0f Ivaylo Ivanov 2025-02-23 451 if (IS_ERR_OR_NULL(phy->ref_clk)) 15a1981f608b0f Ivaylo Ivanov 2025-02-23 @452 return dev_err_probe(dev, PTR_ERR(phy->ref_clk), PTR_ERR(phy->ref_clk) is success. 15a1981f608b0f Ivaylo Ivanov 2025-02-23 453 "failed to get ref clk\n"); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 454 15a1981f608b0f Ivaylo Ivanov 2025-02-23 455 num = ARRAY_SIZE(phy->vregs); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 456 for (i = 0; i < num; i++) 15a1981f608b0f Ivaylo Ivanov 2025-02-23 457 phy->vregs[i].supply = eusb2_hsphy_vreg_names[i]; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 458 15a1981f608b0f Ivaylo Ivanov 2025-02-23 459 ret = devm_regulator_bulk_get(dev, num, phy->vregs); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 460 if (ret) 15a1981f608b0f Ivaylo Ivanov 2025-02-23 461 return dev_err_probe(dev, ret, 15a1981f608b0f Ivaylo Ivanov 2025-02-23 462 "failed to get regulator supplies\n"); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 463 15a1981f608b0f Ivaylo Ivanov 2025-02-23 464 phy->repeater = devm_of_phy_get_by_index(dev, np, 0); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 465 if (IS_ERR(phy->repeater)) 15a1981f608b0f Ivaylo Ivanov 2025-02-23 466 return dev_err_probe(dev, PTR_ERR(phy->repeater), 15a1981f608b0f Ivaylo Ivanov 2025-02-23 467 "failed to get repeater\n"); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 468 15a1981f608b0f Ivaylo Ivanov 2025-02-23 469 generic_phy = devm_phy_create(dev, NULL, &snps_eusb2_hsphy_ops); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 470 if (IS_ERR(generic_phy)) { 15a1981f608b0f Ivaylo Ivanov 2025-02-23 471 dev_err(dev, "failed to create phy %d\n", ret); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 472 return PTR_ERR(generic_phy); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 473 } 15a1981f608b0f Ivaylo Ivanov 2025-02-23 474 15a1981f608b0f Ivaylo Ivanov 2025-02-23 475 dev_set_drvdata(dev, phy); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 476 phy_set_drvdata(generic_phy, phy); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 477 15a1981f608b0f Ivaylo Ivanov 2025-02-23 478 phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 479 if (IS_ERR(phy_provider)) 15a1981f608b0f Ivaylo Ivanov 2025-02-23 480 return PTR_ERR(phy_provider); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 481 15a1981f608b0f Ivaylo Ivanov 2025-02-23 482 dev_info(dev, "Registered Snps-eUSB2 phy\n"); 15a1981f608b0f Ivaylo Ivanov 2025-02-23 483 15a1981f608b0f Ivaylo Ivanov 2025-02-23 484 return 0; 15a1981f608b0f Ivaylo Ivanov 2025-02-23 485 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
