Hi Eric, Thanks for your review feedback. On Wed, 5 Mar 2025 at 02:40, Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > On Wed, Feb 26, 2025 at 10:04:12PM +0000, Peter Griffin wrote: > > PRDT_PREFETCH_ENABLE[31] bit should be set when desctype field of > > fmpsecurity0 register is type2 (double file encryption) or type3 > > (file and disk excryption). Setting this bit enables PRDT > > pre-fetching on both TXPRDT and RXPRDT. > > > > Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx> > > I assume you mean that desctype 3 provides "support for file and disk > encryption"? Yes, the PRDT_PREFETCH_ENABLE description in the commit message I copied from the datasheet. But I can re-word it like you suggest if you think that it's clearer? I notice now there is also a typo with the word 'encryption' which I can also fix. This patch came about whilst comparing UFS SFR register dumps of upstream and downstream drivers. I noticed that PRDT_PREFETCH_ENABLE is enabled downstream but not upstream, and after checking the datasheet description it seemed like we should set this if exynos_ufs_fmp_init() completed and set CFG_DESCTYPE_3. > The driver does use desctype 3, but it only uses the "file > encryption". So this confused me a bit. (BTW, in FMP terminology, "file > encryption" seems to mean "use the key provided in the I/O request", and "disk > encryption" seems to mean "use some key the firmware provided somehow". They > can be cascaded, and the intended use cases are clearly file and disk encryption > respectively, but they don't necessarily have to be used that way.) Thanks for the additional context :) Peter
