On 2/14/25 4:33 AM, Denzeel Oliva wrote: > Rearrange s3c64xx_spi_probe() to ensure that the 'fifo-depth' property > from the device tree (DT) is always prioritized over the fallback > values in port_config. > > Previously, if port_config had a fifo_depth value, it would override > the DT property. This prevented DT from correctly setting the depth > per node. sigh. You had a fifo_depth of 0 in the driver at v1, this proves you didn't test your patches, otherwise you would get a divide by zero. You can't do that, you risk to get your contributions ignored: https://lore.kernel.org/linux-samsung-soc/fbd06330-ccf3-485b-800f-83f624a7c90e@xxxxxxxxxx/ Please provide prove of testing in v4. Anyway, you shouldn't prioritize dt over compatible driver data, see my replies in your v2.
