> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: 31 July 2024 01:44
> To: Swathi K S <swathi.ks@xxxxxxxxxxx>
> Cc: krzk@xxxxxxxxxx; robh@xxxxxxxxxx; davem@xxxxxxxxxxxxx;
> edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; richardcochran@xxxxxxxxx;
> mcoquelin.stm32@xxxxxxxxx; alim.akhtar@xxxxxxxxxxx; linux-
> fsd@xxxxxxxxx; netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx; linux-
> arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx;
> alexandre.torgue@xxxxxxxxxxx; peppe.cavallaro@xxxxxx;
> joabreu@xxxxxxxxxxxx; rcsekar@xxxxxxxxxxx; ssiddha@xxxxxxxxx;
> jayati.sahu@xxxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx;
> ravi.patel@xxxxxxxxxxx; gost.dev@xxxxxxxxxxx
> Subject: Re: [PATCH v4 2/4] net: stmmac: dwc-qos: Add FSD EQoS support
>
> > +static int dwc_eqos_rxmux_setup(void *priv, bool external) {
> > + int i = 0;
> > + struct fsd_eqos_plat_data *plat = priv;
> > + struct clk *rx1 = NULL;
> > + struct clk *rx2 = NULL;
> > + struct clk *rx3 = NULL;
>
> Reverse Christmas tree please.
Thanks for review.
We will take care in next patch version after waiting for other review
comments.
>
> > @@ -264,6 +264,7 @@ struct plat_stmmacenet_data {
> > void (*ptp_clk_freq_config)(struct stmmac_priv *priv);
> > int (*init)(struct platform_device *pdev, void *priv);
> > void (*exit)(struct platform_device *pdev, void *priv);
> > + int (*rxmux_setup)(void *priv, bool external);
> > struct mac_device_info *(*setup)(void *priv);
> > int (*clks_config)(void *priv, bool enabled);
> > int (*crosststamp)(ktime_t *device, struct system_counterval_t
> > *system,
>
> It would be good if one of the stmmas Maintainers looked at this. There
are
> already a lot of function pointers here, we should not be added another
one if
> one of the exiting ones could be used.
>
> Andrew
>
> ---
> pw-bot: cr
