> +static int dwc_eqos_rxmux_setup(void *priv, bool external) > +{ > + int i = 0; > + struct fsd_eqos_plat_data *plat = priv; > + struct clk *rx1 = NULL; > + struct clk *rx2 = NULL; > + struct clk *rx3 = NULL; Reverse Christmas tree please. > @@ -264,6 +264,7 @@ struct plat_stmmacenet_data { > void (*ptp_clk_freq_config)(struct stmmac_priv *priv); > int (*init)(struct platform_device *pdev, void *priv); > void (*exit)(struct platform_device *pdev, void *priv); > + int (*rxmux_setup)(void *priv, bool external); > struct mac_device_info *(*setup)(void *priv); > int (*clks_config)(void *priv, bool enabled); > int (*crosststamp)(ktime_t *device, struct system_counterval_t *system, It would be good if one of the stmmas Maintainers looked at this. There are already a lot of function pointers here, we should not be added another one if one of the exiting ones could be used. Andrew --- pw-bot: cr