On 19/02/2024 20:47, Peter Griffin wrote: >> >>> + >>> + if (property) >>> + pmu_np = of_parse_phandle(np, property, 0); >>> + else >>> + pmu_np = np; >>> + >>> + if (!pmu_np) >>> + return ERR_PTR(-ENODEV); >>> + >>> + /* >>> + * Determine if exynos-pmu device has probed and therefore regmap >>> + * has been created and can be returned to the caller. Otherwise we >>> + * return -EPROBE_DEFER. >>> + */ >>> + dev = driver_find_device_by_of_node(&exynos_pmu_driver.driver, >>> + (void *)pmu_np); >>> + >>> + of_node_put(pmu_np); >> >> You are dropping now referencen from np when property==NULL. This does >> no look right. > > Good spot, will fix. It seems syscon.c and altera-sysmgr also have the > same issue. > Do you plan on fixing them as well in such case? Best regards, Krzysztof
