Hi, > > @@ -590,15 +590,15 @@ static void exynos5433_tmu_control(struct platform_device *pdev, bool on) > > continue; > > > > interrupt_en |= > > - (1 << (EXYNOS7_TMU_INTEN_RISE0_SHIFT + i)); > > + BIT(EXYNOS7_TMU_INTEN_RISE0_SHIFT + i); > > } > > > > interrupt_en |= > > interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT; > > > > - con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT); > > + con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT); > > } else > > Minor issue: the if-else segment here. When the 'if' has the > brackets, then the 'else' should have them as well, > even if there is only a single line under 'else'. > It's not strictly to this patch, but you can address that > later somewhere (just saw it here). For what it's worth, this issue disappears after the final patch of this series, because the other branch reduces to a single line too (all the interrupt_en operations are done in the tmu_set_*_temp functions). Thank you :) Mateusz
