> On 10/11/2023 07:34, Petr Vorel wrote: > > Hi Krzysztof, > >> On 09/11/2023 17:38, Krzysztof Kozlowski wrote: > >>> On 08/11/2023 10:01, Petr Vorel wrote: > >>>> Signed-off-by: Petr Vorel <pvorel@xxxxxxx> > >>>> --- > >> You also lack commit msg explaining why doing this. > > I'm sorry, I thought the reason is obvious - readability. > > Some Makefiles are tried to be sorted (e.g. drivers/clk/qcom/Makefile), > > but lots of them are not (drivers/net/Makefile). Anyway, it's up to you (and > > other maintainers) to judge if it's useful or not. If considered useful, I'll > > send v2. > The commit should come with message justifying it. It's also not clear Sure. > what do you sort - entries are sorted by Kconfig, but you move > CONFIG_EXYNOS_5250_COMMON_CLK. All entries are sorted, i.e. by obj-$() and then by it's entries (items behind +=). At least CONFIG_EXYNOS_ARM64_COMMON_CLK is not sorted. But anyway, feel free to reject this idea immediately, it's not worth of such in depth discussion. Kind regards, Petr > Best regards, > Krzysztof
