Re: [PATCH 1/1] samsung: Sort Makefile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

> On 09/11/2023 17:38, Krzysztof Kozlowski wrote:
> > On 08/11/2023 10:01, Petr Vorel wrote:
> >> Signed-off-by: Petr Vorel <pvorel@xxxxxxx>
> >> ---

> You also lack commit msg explaining why doing this.
I'm sorry, I thought the reason is obvious - readability.

Some Makefiles are tried to be sorted (e.g. drivers/clk/qcom/Makefile),
but lots of them are not (drivers/net/Makefile). Anyway, it's up to you (and
other maintainers) to judge if it's useful or not. If considered useful, I'll
send v2.

> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.

Ah, I'm sorry.  I did this actually (do that each time I send patch for kernel),
but I somehow overlooked "clk: ".

Kind regards,
Petr

> Best regards,
> Krzysztof




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux for Synopsys ARC Processors]    
  • [Linux on Unisoc (RDA Micro) SoCs]     [Linux Actions SoC]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  •   Powered by Linux