Re: [PATCH v2 1/2] pwm: samsung: Fix a bit test in pwm_samsung_resume()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Dan,

On Wed, Oct 25, 2023 at 02:57:34PM +0300, Dan Carpenter wrote:
> The PWMF_REQUESTED enum is supposed to be used with test_bit() and not
> used as in a bitwise AND.  In this specific code the flag will never be
> set so the function is effectively a no-op.
> 
> Fixes: e3fe982b2e4e ("pwm: samsung: Put per-channel data into driver data")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

@Thierry: e3fe982b2e4e is currently in your for-next branch. So it would
be good to get Dan's patch into your PR for 6.7-rc1.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux for Synopsys ARC Processors]    
  • [Linux on Unisoc (RDA Micro) SoCs]     [Linux Actions SoC]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  •   Powered by Linux