Hi Andi, On Tue, 2023-10-24 at 23:55 +0200, Andi Shyti wrote: > Hi Andre, > > On Thu, Oct 19, 2023 at 11:09:01AM +0100, André Draszik wrote: > > When support for various old platforms was removed in commit > > 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks"), > > s3c24xx_serial_ops also became unused here because nothing sets > > port > > type TYPE_S3C24XX anymore. > > > > Remove s3c24xx_serial_ops and all the code that's unreachable now. > > > > Fixes: 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks") > > is this really a fix? Or is it a cleanup? I guess from my position it's fixing the issue of dead code, introduced in the commit referenced. Which is of course also a cleanup :-) Not sure... Cheers, Andre