On Thu, Nov 10, 2022 at 04:48:03PM +0530, Vivek Yadav wrote: > > > > -----Original Message----- > > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Sent: 09 November 2022 16:39 > > To: Vivek Yadav <vivek.2311@xxxxxxxxxxx>; rcsekar@xxxxxxxxxxx; > > krzysztof.kozlowski+dt@xxxxxxxxxx; wg@xxxxxxxxxxxxxx; > > mkl@xxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; > > kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx; > > ravi.patel@xxxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; linux-fsd@xxxxxxxxx; > > robh+dt@xxxxxxxxxx > > Cc: linux-can@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux- > > kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- > > samsung-soc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > > aswani.reddy@xxxxxxxxxxx; sriranjani.p@xxxxxxxxxxx > > Subject: Re: [PATCH v2 1/6] dt-bindings: Document the SYSREG specific > > compatibles found on FSD SoC > > > > On 09/11/2022 11:09, Vivek Yadav wrote: > > > From: Sriranjani P <sriranjani.p@xxxxxxxxxxx> > > > > > > > Use subject prefixes matching the subsystem (git log --oneline -- ...). > > > Okay, I will add the correct prefixes. > > > Describe the compatible properties for SYSREG controllers found on FSD > > > SoC. > > > > This is ARM SoC patch, split it from the patchset. > > > I understand this patch is not to be subset of CAN patches, I will send these patches separately. > These patches will be used by EQos patches. As per reference, I am adding the Address link. > https://lore.kernel.org/all/20221104120517.77980-1-sriranjani.p@xxxxxxxxxxx/ > > > > > > > Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > > > Signed-off-by: Pankaj Kumar Dubey <pankaj.dubey@xxxxxxxxxxx> > > > Signed-off-by: Ravi Patel <ravi.patel@xxxxxxxxxxx> > > > Signed-off-by: Vivek Yadav <vivek.2311@xxxxxxxxxxx> > > > Cc: devicetree@xxxxxxxxxxxxxxx > > > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> > > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > > > Drop the Cc list from commit log. It's not helpful. > > > Okay, I will remove. > > > Signed-off-by: Sriranjani P <sriranjani.p@xxxxxxxxxxx> > > > --- > > > .../devicetree/bindings/arm/tesla-sysreg.yaml | 50 > > +++++++++++++++++++ > > > MAINTAINERS | 1 + > > > 2 files changed, 51 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/arm/tesla-sysreg.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml > > > b/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml > > > new file mode 100644 > > > index 000000000000..bbcc6dd75918 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml > > > > arm is only for top level stuff. This goes to soc under tesla or samsung > > directory. > > > Okay, this is specific to Samsung fsd SoC, I will be moving this file to arm/samsung in next patch series. Hope that is fine. > > > @@ -0,0 +1,50 @@ > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 > > > +--- > > > +$id: > > > +https://protect2.fireeye.com/v1/url?k=1ad2834a-7b59967c-1ad30805- > > 000b > > > +abff9b5d-1f65584e412e916c&q=1&e=a870a282-632a-4896-ae53- > > 3ecb50f02be5& > > > +u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Farm%2Ftesla- > > sysreg.yaml%23 > > > +$schema: > > > +https://protect2.fireeye.com/v1/url?k=13876e33-720c7b05-1386e57c- > > 000b > > > +abff9b5d-edae3ff711999305&q=1&e=a870a282-632a-4896-ae53- > > 3ecb50f02be5& > > > +u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > > > + > > > +title: Tesla Full Self-Driving platform's system registers > > > + > > > +maintainers: > > > + - Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > > > + > > > +description: | > > > + This is a system control registers block, providing multiple low > > > +level > > > + platform functions like board detection and identification, > > > +software > > > + interrupt generation. > > > + > > > +properties: > > > + compatible: > > > + oneOf: > > > > No need for oneOf. > > > Removing this results into dt_binding_check error, so this is required. > > > + - items: > > > + - enum: > > > + - tesla,sysreg_fsys0 > > > + - tesla,sysreg_peric > > > > From where did you get underscores in compatibles? > > > I have seen in MCAN Driver <drivers/net/can/m_can/m_can_platform.c> and also too many other yaml files. > Do you have any ref standard guideline of compatible which says underscore is not allowed. Section 2.3.1 defining 'compatible' in the DT spec: The compatible string should consist only of lowercase letters, digits and dashes, and should start with a letter. A single comma is typically only used following a vendor prefix. Underscores should not be used.
