On 27/05/2022 06:22, Chanho Park wrote: >> Subject: [PATCH 1/7] ARM: dts: s3c2410: use local header for pinctrl >> register values >> >> The DTS uses hardware register values directly in pin controller pin >> configuration. These are not some IDs or other abstraction layer but raw >> numbers used in the registers. >> >> These numbers were previously put in the bindings header to avoid code >> duplication and to provide some context meaning (name), but they do not >> fit the purpose of bindings. It is also quite confusing to use constants >> prefixed with Exynos for other SoC, because there is actually nothing here >> in common, except the actual value. >> >> Store the constants in a header next to DTS and use them instead of >> bindings. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> --- >> arch/arm/boot/dts/s3c2410-pinctrl.h | 19 +++++++++++++ >> arch/arm/boot/dts/s3c2416-pinctrl.dtsi | 38 +++++++++++++------------- >> 2 files changed, 38 insertions(+), 19 deletions(-) create mode 100644 >> arch/arm/boot/dts/s3c2410-pinctrl.h >> >> diff --git a/arch/arm/boot/dts/s3c2410-pinctrl.h >> b/arch/arm/boot/dts/s3c2410-pinctrl.h >> new file mode 100644 >> index 000000000000..71cb0ac815b3 >> --- /dev/null >> +++ b/arch/arm/boot/dts/s3c2410-pinctrl.h >> @@ -0,0 +1,19 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* >> + * Samsung's Exynos pinctrl bindings > > "Exynos" -> "s3c2410" > Thanks, I need to fix it also in other files. Best regards, Krzysztof
