On Thu, Jan 20, 2022 at 9:40 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
...
> +static struct gpiod_lookup_table crag_spi0_gpiod_table = {
> + .dev_id = "s3c6410-spi.0",
> + .table = {
> + GPIO_LOOKUP_IDX("GPIOC", 3, "cs", 0, GPIO_ACTIVE_LOW),
> + GPIO_LOOKUP_IDX("GPION", 5, "cs", 1, GPIO_ACTIVE_LOW),
> + { },
Since it will be v3 of the series, can we remove the comma in the
terminator line?
> + },
> +};
...
> + /* This was dynamically allocated on the DT path */
> + if (spi->dev.of_node)
I believe we may survive w/o this check(s).
> + kfree(cs);
--
With Best Regards,
Andy Shevchenko
