Hi Stephen >-----Original Message----- >From: Stephen Boyd [mailto:sboyd@xxxxxxxxxx] >Sent: Thursday, January 20, 2022 1:45 AM >To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; linux-arm- >kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx >Cc: soc@xxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; >olof@xxxxxxxxx; arnd@xxxxxxxx; linus.walleij@xxxxxxxxxx; >catalin.marinas@xxxxxxx; robh+dt@xxxxxxxxxx; >krzysztof.kozlowski@xxxxxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; linux- >samsung-soc@xxxxxxxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx; Alim Akhtar ><alim.akhtar@xxxxxxxxxxx>; linux-fsd@xxxxxxxxx; Jayati Sahu ><jayati.sahu@xxxxxxxxxxx>; Ajay Kumar <ajaykumar.rs@xxxxxxxxxxx> >Subject: Re: [PATCH v2 04/16] clk: samsung: fsd: Add initial clock support > >Quoting Alim Akhtar (2022-01-18 06:48:39) >> diff --git a/drivers/clk/samsung/clk-fsd.c >> b/drivers/clk/samsung/clk-fsd.c new file mode 100644 index >> 000000000000..2669396d81b9 >> --- /dev/null >> +++ b/drivers/clk/samsung/clk-fsd.c >> @@ -0,0 +1,308 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (c) 2017-2022 Samsung Electronics Co., Ltd. >> + * https://www.samsung.com >> + * Copyright (c) 2017-2022 Tesla, Inc. >> + * https://www.tesla.com >> + * >> + * Common Clock Framework support for FSD SoC. >> + */ >> + >> +#include <linux/clk-provider.h> >> +#include <linux/of.h> > >include init.h for __initconst and kernel.h for ARRAY_SIZE > I did not face any compilation error. Do I need to explicitly add these header files in driver? I see clk.h implicitly includes kernel.h Same is the case of other driver in this directory. >> + >> +#include <dt-bindings/clock/fsd-clk.h> >> + >> +#include "clk.h" >> +
