Hi Chanho >-----Original Message----- >From: Chanho Park [mailto:chanho61.park@xxxxxxxxxxx] >Sent: Friday, September 17, 2021 12:25 PM >To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; Avri Altman ><avri.altman@xxxxxxx>; James E . J . Bottomley <jejb@xxxxxxxxxxxxx>; Martin >K . Petersen <martin.petersen@xxxxxxxxxx>; Krzysztof Kozlowski ><krzysztof.kozlowski@xxxxxxxxxxxxx> >Cc: Bean Huo <beanhuo@xxxxxxxxxx>; Bart Van Assche ><bvanassche@xxxxxxx>; Adrian Hunter <adrian.hunter@xxxxxxxxx>; Christoph >Hellwig <hch@xxxxxxxxxxxxx>; Can Guo <cang@xxxxxxxxxxxxxx>; Jaegeuk Kim ><jaegeuk@xxxxxxxxxx>; Gyunghoon Kwon <goodjob.kwon@xxxxxxxxxxx>; >linux-samsung-soc@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; Chanho Park ><chanho61.park@xxxxxxxxxxx>; Kiwoong Kim <kwmad.kim@xxxxxxxxxxx> >Subject: [PATCH v3 13/17] scsi: ufs: ufs-exynos: add pre/post_hce_enable drv >callbacks > >This patch adds driver-specific pre/post_hce_enable callbacks to execute extra >initializations before and after hce_enable_notify callback. > >Cc: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> >Cc: Kiwoong Kim <kwmad.kim@xxxxxxxxxxx> >Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> >Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx> >--- Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > drivers/scsi/ufs/ufs-exynos.c | 10 ++++++++++ drivers/scsi/ufs/ufs-exynos.h | 2 >++ > 2 files changed, 12 insertions(+) > >diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c index >753b22358186..7fb4514f700d 100644 >--- a/drivers/scsi/ufs/ufs-exynos.c >+++ b/drivers/scsi/ufs/ufs-exynos.c >@@ -1141,6 +1141,12 @@ static int exynos_ufs_hce_enable_notify(struct >ufs_hba *hba, > > switch (status) { > case PRE_CHANGE: >+ if (ufs->drv_data->pre_hce_enable) { >+ ret = ufs->drv_data->pre_hce_enable(ufs); >+ if (ret) >+ return ret; >+ } >+ > ret = exynos_ufs_host_reset(hba); > if (ret) > return ret; >@@ -1150,6 +1156,10 @@ static int exynos_ufs_hce_enable_notify(struct >ufs_hba *hba, > exynos_ufs_calc_pwm_clk_div(ufs); > if (!(ufs->opts & EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL)) > exynos_ufs_enable_auto_ctrl_hcc(ufs); >+ >+ if (ufs->drv_data->post_hce_enable) >+ ret = ufs->drv_data->post_hce_enable(ufs); >+ > break; > } > >diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h index >a0899aaa902e..c291ae51dd41 100644 >--- a/drivers/scsi/ufs/ufs-exynos.h >+++ b/drivers/scsi/ufs/ufs-exynos.h >@@ -154,6 +154,8 @@ struct exynos_ufs_drv_data { > struct ufs_pa_layer_attr *pwr); > int (*post_pwr_change)(struct exynos_ufs *ufs, > struct ufs_pa_layer_attr *pwr); >+ int (*pre_hce_enable)(struct exynos_ufs *ufs); >+ int (*post_hce_enable)(struct exynos_ufs *ufs); > }; > > struct ufs_phy_time_cfg { >-- >2.33.0