On Tue, Sep 21, 2021 at 1:19 AM Lee Jones <lee.jones@xxxxxxxxxx> wrote: > > On Tue, 21 Sep 2021, Krzysztof Kozlowski wrote: > > > On 20/09/2021 21:03, Will McVicker wrote: > > > Switch the default logic to enable SOC_SAMSUNG and it's sub-configs to > > > be enabled by default via "default y if ARCH_EXYNOS" versus being > > > selected by the ARCH_EXYNOS config directly. This allows vendors to > > > disable these configs if they wish and provides additional flexibility > > > to modularize them in the presence of a generic kernel. > > > > This is not true. Vendors cannot disable these options as they are not > > visible. > > Good point, well made. > > > Although I understand that Arnd prefers this way and I do not > > object it, but your explanation is incorrect. Thanks Krzysztof for the reviews! I'm sorry I missed the whole "hidden configs" part. I'll upload the series to include the fix that refactos the Samsung SoC drivers menuconfig which will address that and allow one to enable/disable those configs. I'm going to hold off though until we hash out the rest of the discussion in the cover letter email. Thanks, Will > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog