On 20/09/2021 21:03, Will McVicker wrote: > Switch the default logic to enable SOC_SAMSUNG and it's sub-configs to > be enabled by default via "default y if ARCH_EXYNOS" versus being > selected by the ARCH_EXYNOS config directly. This allows vendors to > disable these configs if they wish and provides additional flexibility > to modularize them in the presence of a generic kernel. This is not true. Vendors cannot disable these options as they are not visible. Although I understand that Arnd prefers this way and I do not object it, but your explanation is incorrect. > > There are no .config differences with this change. The configs > SOC_SAMSUNG, EXYNOS_CHIPID, EXYNOS_PM_DOMAINS, and EXYNOS_PMU still > remain enabled by default. > > Signed-off-by: Will McVicker <willmcvicker@xxxxxxxxxx> > --- > arch/arm64/Kconfig.platforms | 4 ---- > drivers/soc/samsung/Kconfig | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 3a66ed43088d..6a006490c9b9 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -91,14 +91,10 @@ config ARCH_BRCMSTB > > config ARCH_EXYNOS > bool "ARMv8 based Samsung Exynos SoC family" > - select EXYNOS_CHIPID This will conflict with: https://lore.kernel.org/linux-samsung-soc/CAGOxZ50i6URzUQ7o7V4m7MR=2TqSeD6qx5fQaQDs+5nEq4fa2A@xxxxxxxxxxxxxx/T/#t Build on top of it, please. Best regards, Krzysztof