On Sun, Aug 02, 2020 at 04:25:53PM +0200, Krzysztof Wilczyński wrote:
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
>
> This change is as per suggestion from Coccinelle:
>
> drivers/pci/controller/dwc/pcie-armada8k.c:252:2-9: line 252 is
> redundant because platform_get_irq() already prints an error
>
> drivers/pci/controller/dwc/pcie-kirin.c:459:3-10: line 459 is
> redundant because platform_get_irq() already prints an error
>
> drivers/pci/controller/dwc/pci-imx6.c:872:3-10: line 872 is redundant
> because platform_get_irq() already prints an error
>
> drivers/pci/controller/dwc/pcie-artpec6.c:391:3-10: line 391 is
> redundant because platform_get_irq() already prints an error
>
> drivers/pci/controller/dwc/pcie-spear13xx.c:202:2-9: line 202 is
> redundant because platform_get_irq() already prints an error
>
> drivers/pci/controller/dwc/pci-keystone.c:1254:2-9: line 1254 is
> redundant because platform_get_irq() already prints an error
>
> drivers/pci/controller/dwc/pci-exynos.c:406:2-9: line 406 is redundant
> because platform_get_irq() already prints an error
>
> drivers/pci/controller/dwc/pci-exynos.c:419:3-10: line 419 is
> redundant because platform_get_irq() already prints an error
>
> drivers/pci/controller/dwc/pcie-tegra194.c:2193:2-9: line 2193 is
> redundant because platform_get_irq() already prints an error
>
> drivers/pci/controller/dwc/pcie-histb.c:406:3-10: line 406 is
> redundant because platform_get_irq() already prints an error
>
> drivers/pci/controller/dwc/pci-meson.c:492:3-10: line 492 is redundant
> because platform_get_irq() already prints an error
>
> drivers/pci/controller/dwc/pci-dra7xx.c:633:2-9: line 633 is redundant
> because platform_get_irq() already prints an error
>
> drivers/pci/controller/dwc/pci-dra7xx.c:875:2-9: line 875 is redundant
> because platform_get_irq() already prints an error
>
> Suggested-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Signed-off-by: Krzysztof Wilczyński <kw@xxxxxxxxx>
Looks good,
Acked-by: Jesper Nilsson <jesper.nilsson@xxxxxxxx>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@xxxxxxxx
