On 10/16/19 18:16, Krzysztof Kozlowski wrote: >> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml >> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml >> @@ -9,17 +9,42 @@ title: Samsung Exynos SoC series Chipid driver BTW, I think we should rename the above title to talk about IP block/device rather than driver, e.g. -SAMSUNG Exynos SoCs Chipid driver. +SAMSUNG Exynos SoC series CHIPID subsystem >> +# Custom select to avoid matching all nodes with 'syscon' >> +select: >> + properties: >> + compatible: >> + contains: >> + const: samsung,exynos4210-chipid >> + required: >> + - compatible >> + >> properties: >> compatible: >> - items: >> - - const: samsung,exynos4210-chipid >> + allOf: > > I think it was my mistake to use allOf in other Exynos bindings. It > should not be needed. Indeed it seems to work well without allOf, I was wondering why we needed the custom select above AND allOf.
