On Wed, 16 Oct 2019 at 17:58, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote:
>
> This patch adds documentation of new optional "samsung,asv-bin"
> property in the chipid device node and documents requirement of
> "syscon" compatible string. These additions are needed to support
> Exynos ASV (Adaptive Supply Voltage) feature.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> ---
> Depends on patch ("8d0daa4c89c9 dt-bindings: arm: samsung: Convert
> Exynos Chipid bindings to json-schema") already applied to Rob's
> dt/next.
>
> Changes since v4:
> - converted to YAML
>
> Changes since v3:
> - none
>
> Changes since v2:
> - corrected patch summary line prefix, the patch moved in the
> sequence
>
> Changes since v1 (RFC):
> - new patch
>
> .../bindings/arm/samsung/exynos-chipid.yaml | 31 +++++++++++++++++--
> 1 file changed, 28 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> index 9c573ad7dc7d..df84d9e9f4c2 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> @@ -9,17 +9,42 @@ title: Samsung Exynos SoC series Chipid driver
> maintainers:
> - Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> +# Custom select to avoid matching all nodes with 'syscon'
> +select:
> + properties:
> + compatible:
> + contains:
> + const: samsung,exynos4210-chipid
> + required:
> + - compatible
> +
> properties:
> compatible:
> - items:
> - - const: samsung,exynos4210-chipid
> + allOf:
I think it was my mistake to use allOf in other Exynos bindings. It
should not be needed.
Rest looks good so with allOf removal:
Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Best regards,
Krzysztof
