2019年10月16日(水) 19:55 Markus Elfring <Markus.Elfring@xxxxxx>: > > >> * Is there a need to adjust the error handling here? > > > > No, there isn't much that can be done if we fail the allocation at > > such an early stage. > > Can it matter to perform the setting “pll->rate_count” only according > to a null pointer check for the variable “pll->rate_table” > because of the function call “kmemdup”? It would be a good practice indeed, but looking from the code, pll->rate_table is checked elsewhere, not pll->rate_count. Best regards, Tomasz
