>> * Is there a need to adjust the error handling here? > > No, there isn't much that can be done if we fail the allocation at > such an early stage. Can it matter to perform the setting “pll->rate_count” only according to a null pointer check for the variable “pll->rate_table” because of the function call “kmemdup”? Regards, Markus