Hi Chanwoo,
On Mon, 26 Nov 2018 at 13:18, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote:
>
> Hi,
>
> On 2018년 11월 23일 18:44, Anand Moon wrote:
> > From: Marian Mihailescu <mihailescu2m@xxxxxxxxx>
> >
> > A specific clock rate table is added for VPLL so it is possible
> > to set frequency of the VPLL output clock that used by the g3d clock.
> >
> > Cc: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> > Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> > Signed-off-by: Marian Mihailescu <mihailescu2m@xxxxxxxxx>
> > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
> > ---
> > drivers/clk/samsung/clk-exynos5420.c | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c
> > index 34cce3c5898f..34156bdfd0d2 100644
> > --- a/drivers/clk/samsung/clk-exynos5420.c
> > +++ b/drivers/clk/samsung/clk-exynos5420.c
> > @@ -1303,6 +1303,18 @@ static const struct samsung_pll_rate_table exynos5420_epll_24mhz_tbl[] = {
> > PLL_36XX_RATE(24 * MHZ, 32768001U, 131, 3, 5, 4719),
> > };
> >
> > +static const struct samsung_pll_rate_table exynos5420_vpll_24mhz_tbl[] __initconst = {
> > + PLL_35XX_RATE(24 * MHZ, 600000000U, 200, 2, 2),
> > + PLL_35XX_RATE(24 * MHZ, 543000000U, 181, 2, 2),
> > + PLL_35XX_RATE(24 * MHZ, 533000000U, 533, 6, 2),
> > + PLL_35XX_RATE(24 * MHZ, 480000000U, 320, 4, 2),
> > + PLL_35XX_RATE(24 * MHZ, 420000000U, 140, 2, 2),
> > + PLL_35XX_RATE(24 * MHZ, 350000000U, 175, 3, 2),
> > + PLL_35XX_RATE(24 * MHZ, 266000000U, 266, 3, 3),
> > + PLL_35XX_RATE(24 * MHZ, 177000000U, 118, 2, 3),
> > + PLL_35XX_RATE(24 * MHZ, 100000000U, 200, 3, 4),
> > +};
>
> VPLL has the same PMS table with apll/kpll/bpll. You don't need to add new
> 'exynos5420_vpll_24mhz_tbl' table. Just adding the missing frequency entries
> to 'exynos5420_pll2550x_24mhz_tbl' table.
>
Thanks for your input. I will leave this for the expert to fix this.
> > +
> > static struct samsung_pll_clock exynos5x_plls[nr_plls] __initdata = {
> > [apll] = PLL(pll_2550, CLK_FOUT_APLL, "fout_apll", "fin_pll", APLL_LOCK,
> > APLL_CON0, NULL),
> > @@ -1428,6 +1440,7 @@ static void __init exynos5x_clk_init(struct device_node *np,
> > exynos5x_plls[epll].rate_table = exynos5420_epll_24mhz_tbl;
> > exynos5x_plls[kpll].rate_table = exynos5420_pll2550x_24mhz_tbl;
> > exynos5x_plls[bpll].rate_table = exynos5420_pll2550x_24mhz_tbl;
> > + exynos5x_plls[vpll].rate_table = exynos5420_vpll_24mhz_tbl;
> > }
> >
> > samsung_clk_register_pll(ctx, exynos5x_plls, ARRAY_SIZE(exynos5x_plls),
> >
>
>
> --
> Best Regards,
> Chanwoo Choi
> Samsung Electronics
Best Regards
-Anand
