On 27.07.2015 23:57, Kukjin Kim wrote: > > This patch moves regs-srom header file into mach-exynos. Hi, Minor nits: 1. Could you trim it and remove unnecessary empty line before description? 2. Could you answer in commit message: Why? Why are you moving the headers? > > c: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> Malformed "Cc:" tag. Best regards, Krzysztof > Signed-off-by: Kukjin Kim <kgene@xxxxxxxxxx> > --- > arch/arm/{plat-samsung/include/plat => mach-exynos}/regs-srom.h | 3 +-- > arch/arm/mach-exynos/suspend.c | 4 ++-- > 2 files changed, 3 insertions(+), 4 deletions(-) > rename arch/arm/{plat-samsung/include/plat => mach-exynos}/regs-srom.h (96%) > > diff --git a/arch/arm/plat-samsung/include/plat/regs-srom.h b/arch/arm/mach-exynos/regs-srom.h > similarity index 96% > rename from arch/arm/plat-samsung/include/plat/regs-srom.h > rename to arch/arm/mach-exynos/regs-srom.h > index 9b6729c..5c4d442 100644 > --- a/arch/arm/plat-samsung/include/plat/regs-srom.h > +++ b/arch/arm/mach-exynos/regs-srom.h > @@ -1,5 +1,4 @@ > -/* linux/arch/arm/plat-samsung/include/plat/regs-srom.h > - * > +/* > * Copyright (c) 2010 Samsung Electronics Co., Ltd. > * http://www.samsung.com > * > diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c > index c506f8e..e00eb39 100644 > --- a/arch/arm/mach-exynos/suspend.c > +++ b/arch/arm/mach-exynos/suspend.c > @@ -32,11 +32,11 @@ > #include <asm/suspend.h> > > #include <plat/pm-common.h> > -#include <plat/regs-srom.h> > > #include "common.h" > -#include "regs-pmu.h" > #include "exynos-pmu.h" > +#include "regs-pmu.h" > +#include "regs-srom.h" > > #define REG_TABLE_END (-1U) > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html