Krzysztof Kozlowski wrote: > > On 27.07.2015 23:57, Kukjin Kim wrote: > > > > This patch moves regs-srom header file into mach-exynos. > > Hi, > Hi, > Minor nits: > 1. Could you trim it and remove unnecessary empty line before description? Yeah, actually I couldn't use git send-email when I submitted but just used e-mail. It should be fine in my local branch. > 2. Could you answer in commit message: Why? Why are you moving the headers? > OK, basically we don't need to keep headers in <mach/xxx> and <plat/xxx> if it is not required. For example, actually common.h files in mach-xxxx/ have been made/moved because of the reason before. Someday we did because it was required to support multi_v7 as well. Anyway it is still required and note that I have some more patches to move headers which are used only for under drivers/ not arch side into drivers/. And next step is removing some definitions which are not used more. > > > > c: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > > Malformed "Cc:" tag. > Oh, OK. Thanks. One more thing, please ignore patch "[09/12] ARM: SAMSUNG: local keypad header in mach-s3c64xx" in this series because the header is used in plat-samsung as well. Anyway, thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |