On Tuesday, November 18, 2014 8:47 PM, Sylwester Nawrocki Wrote:
> On 18/11/14 11:47, Pankaj Dubey wrote:
> > Let's register restart handler for Exynos5440 from it's clock driver
> > for restart functionality. So that we can cleanup restart hooks from
> > machine specific file.
> >
> > CC: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> > CC: Tomasz Figa <tomasz.figa@xxxxxxxxx>
> > Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>
> > Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>
> The patch looks good to me.
>
> Acked-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
>
> Just one comment below.
>
Thanks for review.
> > ---
> > arch/arm/mach-exynos/exynos.c | 19 +------------------
> > drivers/clk/samsung/clk-exynos5440.c | 29
> ++++++++++++++++++++++++++++-
> > 2 files changed, 29 insertions(+), 19 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/exynos.c
> > b/arch/arm/mach-exynos/exynos.c index 8f638ad..8f995b7 100644
> > --- a/arch/arm/mach-exynos/exynos.c
> > +++ b/arch/arm/mach-exynos/exynos.c
> > @@ -89,24 +89,7 @@ static struct map_desc exynos5_iodesc[] __initdata
> > = {
> >
> > static void exynos_restart(enum reboot_mode mode, const char *cmd) {
> > - struct device_node *np;
> > - u32 val = 0x1;
> > - void __iomem *addr = pmu_base_addr + EXYNOS_SWRESET;
> > -
> > - if (of_machine_is_compatible("samsung,exynos5440")) {
> > - u32 status;
> > - np = of_find_compatible_node(NULL, NULL,
"samsung,exynos5440-
> clock");
> > -
> > - addr = of_iomap(np, 0) + 0xbc;
> > - status = __raw_readl(addr);
> > -
> > - addr = of_iomap(np, 0) + 0xcc;
> > - val = __raw_readl(addr);
> > -
> > - val = (val & 0xffff0000) | (status & 0xffff);
> > - }
> > -
> > - __raw_writel(val, addr);
> > + __raw_writel(0x1, pmu_base_addr + EXYNOS_SWRESET);
> > }
> >
>
> > +static int exynos5440_clk_restart_notify(struct notifier_block *this,
> > + unsigned long code, void *unused)
> > +{
> > + u32 val, status;
> > +
> > + status = readl_relaxed(reg_base + 0xbc);
> > + val = readl_relaxed(reg_base + 0xcc);
> > + val = (val & 0xffff0000) | (status & 0xffff);
> > + writel_relaxed(val, reg_base + 0xcc);
>
> Can we have macro definitions for these 0xcc, 0xbc address offsets ?
> I must say I couldn't find them documented in any Exynos datasheet I've
got though.
>
I also wished this, but I could not find them documented.
So I tried to keep logic of original code as it is, just changed location.
I would also like to mention that I have not tested this on exynos5440 as I
do not have
one with me. I believe if it was working at its original place in
exynos_restart it should work
here also. Other patch (2/2) I have verified on Exynos3250 board and its
working well.
Thanks,
Pankaj Dubey
> > + return NOTIFY_DONE;
> > +}
>
> --
> Regards,
> Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
