+Bartlomiej Zolnierkiewicz Hello Marek, On Wed, Aug 20, 2014 at 8:29 AM, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote: >>> >>> Yes, discussed in the thread titled "[PATCH 1/2] ARM: dts: Enable PMIC >>> interrupts on ODROID" >>> Those patches weren't important for boot at the time of submission, >>> but it looks like something else changed (the max77686 driver?) that >>> makes them now required. >> >> Excellent, thanks. A bummer we didn't see this earlier, but let's get >> the fix in asap. > > > I've also posted a fix to MAX77686 driver, which restores v3.16-like > behavior > of PMIC driver. I hope it will get merged to one of v3.17 rc series. > Bartlomiej posted a similar patch [0] before but as I said on that thread, I'm not sure if is correct to make that DT property optional. Or rather, if we need to make it optional then we should also change the Documentation/devicetree/bindings/mfd/max77686.txt that list "interrupts" DT property as required. It's true that before converting the max77686 to use the regmap irq API, the driver was loose on that regard but max77686_irq_init() in max77686-irq.c was returning -ENODEV when the IRQ was not provided and that error code was not checked in max77686_i2c_probe() which was a bug IMHO. More importantly I wonder if a design where a IRQ line is not connected to the max77686 PMIC makes even sense. If such a design is possible then the "interrupt" property should be optional but if not then I think that the driver should fail to probe in that case. Yes, it is a regression but also the Odroid DTS was not following the DT binding and was just lucky that the driver was not checking the required DT properties. So I tend to say that Daniel's fix should be added as a -rc fix and we should keep both the max77686 driver and its DT binding as it is now but as I said, if from a hardware point of view makes sense to leave that line unconnected then I don't oppose to this change. > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland > Best regards, Javier [0]: https://lkml.org/lkml/2014/8/7/374 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |