On Wed, Aug 20, 2014 at 8:18 AM, Javier Martinez Canillas <javier@xxxxxxxxxxxx> wrote: > More importantly I wonder if a design where a IRQ line is not > connected to the max77686 PMIC makes even sense. If such a design is > possible then the "interrupt" property should be optional but if not > then I think that the driver should fail to probe in that case. Yes, > it is a regression but also the Odroid DTS was not following the DT > binding and was just lucky that the driver was not checking the > required DT properties. I think it would not be totally unreasonable to have such a design with no IRQ line hookup - after all we just did a load of ODROID work on 3.16 without this interrupt being available, and we didn't notice. At the same time, I think its unlikely that someone wouldn't just hook this up, it is sensible to put this kind of thing on the board even if you don't have an immediate need for it, and all the reference designs will have it. No strong preference but I would vote for the slightly simpler option of having the max77686 driver require the interrupt specified (like now), until someone comes along with a board that physically lacks it. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |