Hi Mark, On Mon, Dec 9, 2013 at 5:30 PM, Padma Venkat <padma.kvr@xxxxxxxxx> wrote: > Hi Mark, > > On Fri, Dec 6, 2013 at 4:57 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: >> On Fri, Dec 06, 2013 at 10:44:33AM +0530, Padma Venkat wrote: >> >>> This is done in your earlier patch " ASoC: samsung: Ensure DMA data is >>> initialised for secondary DAI ". Was it done on purpose or by mistake >>> in this patch? >> >> It's intentional - notice that the function has changed, this is why I >> kept asking you about mainline. Mainline doesn't have the wrapper >> function that abstracts the difference between s3c-dma and dmaengine, >> this is why I'm saying these two will need to be rebased on top of the >> mainline fix. > > Ok. I didn't notice the function name. Then this commit is not > required in the mainline. > This is required only after your changes because in dmaengine we are > requesting the dma channel statically but in mainline(with samsung > proprietary ops) we are requesting the dma channel at run time during > playback or capture. sorry for the mix-up. I think we need to set the dma data for the secondary dai even in mainline. > >> >>> I think you also told to include a patch for reinitialization of the >>> dma_data in i2s_hw_params. If you are in the process of debugging some >>> bug as you mentioned earlier you can ignore this comment. Otherwise it >>> is just a reminder. >> >> Hrm, forgot to commit that bit. > > Thanks > Padma -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |