Hi Naveen, Andrew, Please see my comments inline. On Tuesday 12 of November 2013 12:07:05 Naveen Krishna Chatradhi wrote: > Exynos5420 has 5 TMU channels, the TRIMINFO register is > misplaced for TMU channels 2, 3 and 4 > TRIMINFO at 0x1006c000 contains data for TMU channel 3 > TRIMINFO at 0x100a0000 contains data for TMU channel 4 > TRIMINFO at 0x10068000 contains data for TMU channel 2 > > This patch > 1 Adds the neccessary register changes and arch information > to support Exynos5420 SoCs. > 2. Handles the gate clock for misplaced TRIMINFO register > 3. Updates the Documentation at > Documentation/devicetree/bindings/thermal/exynos-thermal.txt > > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@xxxxxxxxxxx> > Signed-off-by: Andrew Bresticker <abrestic@xxxxxxxxxxxx> > --- > Changes since v8: > 1. rewrote the Documentation for device tree bindings > 2. Merged the https://lkml.org/lkml/2013/11/7/262 (as this is a fix) > 3. introduces "samsung,exynos5420-tmu-triminfo" and > "samsung,exynos5420-tmu-triminfo-clk" to handle the TMU channels on > Exynos5420 more appropriately > > .../devicetree/bindings/thermal/exynos-thermal.txt | 45 +++++++++ > drivers/thermal/samsung/exynos_tmu.c | 58 ++++++++++- > drivers/thermal/samsung/exynos_tmu.h | 2 + > drivers/thermal/samsung/exynos_tmu_data.c | 106 ++++++++++++++++++++ > drivers/thermal/samsung/exynos_tmu_data.h | 8 ++ > 5 files changed, 215 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt > index 116cca0..5055b31 100644 > --- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt > @@ -6,6 +6,11 @@ > "samsung,exynos4412-tmu" > "samsung,exynos4210-tmu" > "samsung,exynos5250-tmu" > + "samsung,exynos5420-tmu" for TMU channel 0, 1 on Exynos5420 > + "samsung,exynos5420-tmu-triminfo" for TMU channel 2 Exynos5420 > + (Must pass triminfo base) > + "samsung,exynos5420-tmu-triminfo-clk" for TMU channel 3 and 4 > + Exynos5420 (Must pass triminfo base and triminfo clock) I don't think you need those two separate compatible values. Instead you can keep only the one that requires clock and specify the same base clock as triminfo clock. Also IMHO "samsung,exynos5420-tmu-ext-triminfo" would be a better name, as it describes the hardware better (TMU with external triminfo block, as opposed to normal TMU that has it internally). Otherwise the patch looks fine. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |