Hi Mark, On Thu, Nov 28, 2013 at 5:08 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Thu, Nov 28, 2013 at 03:32:12PM +0530, Padmavathi Venna wrote: > >> This is made based on Mark Brown for-next branch of sound.git >> This patch is based on Mark Brown below patches for >> generic dma engine support for samsung audio IPs. >> ASoC: samsung: Use ASoC dmaengine code where possible >> ASoC: samsung: Provide helper for DMA init > > Why don't we need this fix for mainline? The dmaengine change is just > moving the initialisation through a layer of indirection but there was > initialisation anyway. I'm concerned that there's a bug that ought to > be fixed for v3.13 as well here. Yes. We need this for mainline. Not dependent on your dmaengine changes. > >> return snd_dmaengine_pcm_register(dev, &samsung_dmaengine_pcm_config, >> - SND_DMAENGINE_PCM_FLAG_COMPAT); >> + SND_DMAENGINE_PCM_FLAG_COMPAT | >> + SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME); > > This is already done. Should I send another patch by removing this flag from this patch? Thanks Padma -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html