Hi Jingoo, On Thursday 10 of October 2013 11:40:22 Jingoo Han wrote: > On Thursday, October 10, 2013 11:26 AM, Sylwester Nawrocki wrote: > > On 10/10/2013 11:02 AM, Jingoo Han wrote: > > > Since commit ca91435 "ARM: EXYNOS: Remove unused board files", > > > s5p_device_ehci is not used anymore. Thus, s5p_device_ehci can > > > be removed. Also, unnecessary S5P_DEV_USB_EHCI option is removed. > > > > > > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> > > > > Reviewed-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > > > > > diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c > > > index 8ce0ac0..25f40c9 100644 > > > --- a/arch/arm/plat-samsung/devs.c > > > +++ b/arch/arm/plat-samsung/devs.c > > > @@ -49,7 +49,6 @@ > > > > > > #include <plat/devs.h> > > > #include <plat/adc.h> > > > #include <linux/platform_data/ata-samsung_cf.h> > > > > > > -#include <linux/platform_data/usb-ehci-s5p.h> > > > > Are you planning to remove also this file altogether ? Probably the > > s5p-ehci driver could be cleaned up then and the platform_data handling > > dropped from it as a follow up. > > Hi Sylwester Nawrocki, > > I will rename s5p-ehci to s5p-exynos, then drop platform_data handling > from it. These will be separate patches. > Thank you your comment. :-) I'd recommend keeping driver name as is. S5PV210 is going to receive DT support soon and it will be also able to use this driver. Otherwise this looks fine. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |