On Tue, Oct 16, 2012 at 10:25 AM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote: > int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip, > unsigned int off, samsung_gpio_pull_t pull) > { > @@ -599,7 +593,7 @@ static int samsung_gpiolib_4bit_input(struct gpio_chip *chip, > con &= ~(0xf << con_4bit_shift(offset)); > __raw_writel(con, base + GPIOCON_OFF); > > - gpio_dbg("%s: %p: CON now %08lx\n", __func__, base, con); > + pr_debug("%s: %p: CON now %08lx\n", __func__, base, con); Does your struct gpio_chip provide a valid dev pointer so you can use: dev_dbg(chip->dev, "%s: %p: CON now %08lx\n", __func__, base, con); In that case use the dev_* print macros everywhere instead. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html