On 22 August 2012 20:24, Chris Ball <cjb@xxxxxxxxxx> wrote: > Hi Thomas, > > On Wed, Aug 22 2012, Thomas Abraham wrote: >>> none -> currently "samsung,sdhci-cd-internal" >>> broken-cd -> currently "samsung,sdhci-cd-none" >>> cd-gpios -> currently "samsung,sdhci-cd-gpios" >>> non-removable -> currently "samsung,sdhci-cd-permanent" >>> cd-gpios + samsung,sdhci-cd-external -> currently "samsung,sdhci-cd-external" >>> >>> How does that sound? >> >> Not quite there yet. It is not possible to leave out cd-gpios for >> "samsung,sdhci-cd-internal" since the current Samsung pinmux >> configuration piggybacks on gpio dt binding. Can we use the following >> instead. >> >> none -> currently "samsung,sdhci-cd-none" >> broken-cd -> currently "samsung,sdhci-cd-none" >> cd-gpios -> currently "samsung,sdhci-cd-gpios" >> non-removable -> currently "samsung,sdhci-cd-permanent" >> cd-gpios + samsung,sdhci-cd-internal -> currently "samsung,sdhci-cd-internal" > > I see. Okay; unless anyone has better ideas, it sounds like you should > go ahead and do that -- with something like this in your binding docs: Ok. > > "This binding differs from the core MMC binding by requiring a cd-gpios > property to be present to use internal card-detection. If no cd-gpios > are present (and "non-removable" is missing) the driver will poll for > card-detection as if a "broken-cd" property was provided." > > I'll send out the new core bindings doc shortly. Finishing off another > thread -- the "samsung-sdhci.txt" name is okay. Thanks Chris for your time on this subject. I will prepare the sdhci-s3c dt support patch on top of your new core bindings patch. Thanks, Thomas. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |