On 22 August 2012 16:38, Chris Ball <cjb@xxxxxxxxxx> wrote: > Hi Thomas, > > On Wed, Aug 22 2012, Thomas Abraham wrote: >>> This matches Mitch's last suggestion exactly -- I think we're all agreed >>> on these properties now. The only remaining question is how to handle >>> the pinctrl for CD in Thomas's case. >> >> Hi Chris, >> >> For sdhci-s3c driver, the 'broken-cd' and 'cd-gpios' bindings are >> sufficient. But, are drivers free to use implementation specific >> behavior when using these bindings. Or do we strictly adhere to the >> table which Shawn has listed. For sdhci-s3c driver, I would like to >> deviate from the "implication" column listed above. > > I'd rather you use the implications described above for the names > described above; there's not much point in defining named behaviors > across the subsystem if they're actually different in each driver. Ok. > > But I think you can still use driver-internal properties that change the > interpretation of those names in a documented way. If the meaning of > cd-gpios is modified when coupled with your "samsung,sdhci-cd-external", > that's okay with me. That should cover all the cases you need until you > migrate to using pinctrl, right? So, you could immediately support: > > none -> currently "samsung,sdhci-cd-internal" > broken-cd -> currently "samsung,sdhci-cd-none" > cd-gpios -> currently "samsung,sdhci-cd-gpios" > non-removable -> currently "samsung,sdhci-cd-permanent" > cd-gpios + samsung,sdhci-cd-external -> currently "samsung,sdhci-cd-external" > > How does that sound? Not quite there yet. It is not possible to leave out cd-gpios for "samsung,sdhci-cd-internal" since the current Samsung pinmux configuration piggybacks on gpio dt binding. Can we use the following instead. none -> currently "samsung,sdhci-cd-none" broken-cd -> currently "samsung,sdhci-cd-none" cd-gpios -> currently "samsung,sdhci-cd-gpios" non-removable -> currently "samsung,sdhci-cd-permanent" cd-gpios + samsung,sdhci-cd-internal -> currently "samsung,sdhci-cd-internal" Thanks Chris. Regards, Thomas. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |