On 04/19/2012 08:01 AM, Kukjin Kim wrote:
> Jaehoon Chung wroteh:
>> On 04/19/2012 09:12 AM, Kukjin Kim wrote:
>>
>>> Jaehoon Chung wrote:
>>>> In dev-dwmci.c, IRQ_DWMCI is referenced.
>>>> But there is no defined anywhere.
>>>> This patch is added the missing definition for IRQ_DWMCI.
>>>>
>>>> Signed-off-by: Jaehoon Chung<jh80.chung@xxxxxxxxxxx>
>>>> Signed-off-by: Kyungmin Park<Kyungmin.park@xxxxxxxxxxx>
>>>> ---
>>>> arch/arm/mach-exynos/include/mach/irqs.h | 1 +
>>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/arch/arm/mach-exynos/include/mach/irqs.h
>>>> b/arch/arm/mach-exynos/include/mach/irqs.h
>>>> index 1161675..ed2295f 100644
>>>> --- a/arch/arm/mach-exynos/include/mach/irqs.h
>>>> +++ b/arch/arm/mach-exynos/include/mach/irqs.h
>>>> @@ -201,6 +201,7 @@
>>>> #define IRQ_HSMMC1 EXYNOS4_IRQ_HSMMC1
>>>> #define IRQ_HSMMC2 EXYNOS4_IRQ_HSMMC2
>>>> #define IRQ_HSMMC3 EXYNOS4_IRQ_HSMMC3
>>>> +#define IRQ_DWMCI EXYNOS4_IRQ_DWMCI
>>>
>>> Yeah, we need fix it but I have no idea need re-mapping. Just
>>> following can do it. If you're ok on following, let me pick this up.
>>
>> If it's working, i don't care..I didn't see the
>> DEFINE_RES_MEM/DEFINE_RES_IRQ.
>> But if we can use them, it's more readable.
>>
> Yes, this should be working fine. And note, need inclusion of
> <linux/ioport.h> for DEFINE_RES_{MEM,IRQ}.
>
We should not require explicit inclusion of <linux/ioport.h> here. The
definition of "struct resource {" and DEFINE_RES_{MEM,IRQ}" are in same
ioport.h file. Hence if "struct resource {" is accessible here,
"DEFINE_RES_{MEM,IRQ}" would also be accessible.
> If any problems, please let me know.
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-samsung-soc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
