On 04/19/2012 09:12 AM, Kukjin Kim wrote:
> Jaehoon Chung wrote:
>> In dev-dwmci.c, IRQ_DWMCI is referenced.
>> But there is no defined anywhere.
>> This patch is added the missing definition for IRQ_DWMCI.
>>
>> Signed-off-by: Jaehoon Chung<jh80.chung@xxxxxxxxxxx>
>> Signed-off-by: Kyungmin Park<Kyungmin.park@xxxxxxxxxxx>
>> ---
>> arch/arm/mach-exynos/include/mach/irqs.h | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/include/mach/irqs.h b/arch/arm/mach-exynos/include/mach/irqs.h
>> index 1161675..ed2295f 100644
>> --- a/arch/arm/mach-exynos/include/mach/irqs.h
>> +++ b/arch/arm/mach-exynos/include/mach/irqs.h
>> @@ -201,6 +201,7 @@
>> #define IRQ_HSMMC1 EXYNOS4_IRQ_HSMMC1
>> #define IRQ_HSMMC2 EXYNOS4_IRQ_HSMMC2
>> #define IRQ_HSMMC3 EXYNOS4_IRQ_HSMMC3
>> +#define IRQ_DWMCI EXYNOS4_IRQ_DWMCI
>
> Yeah, we need fix it but I have no idea need re-mapping. Just following can do it. If you're ok on following, let me pick this up.
If it's working, i don't care..I didn't see the DEFINE_RES_MEM/DEFINE_RES_IRQ.
But if we can use them, it's more readable.
Thanks,
Jaehoon Chung
>
> ---
> diff --git a/arch/arm/mach-exynos/dev-dwmci.c b/arch/arm/mach-exynos/dev-dwmci.c
> index b025db4..c78daf2 100644
> --- a/arch/arm/mach-exynos/dev-dwmci.c
> +++ b/arch/arm/mach-exynos/dev-dwmci.c
> @@ -33,16 +31,8 @@ static int exynos4_dwmci_init(u32 slot_id, irq_handler_t handler, void *data)
> }
>
> static struct resource exynos4_dwmci_resource[] = {
> - [0] = {
> - .start = EXYNOS4_PA_DWMCI,
> - .end = EXYNOS4_PA_DWMCI + SZ_4K - 1,
> - .flags = IORESOURCE_MEM,
> - },
> - [1] = {
> - .start = IRQ_DWMCI,
> - .end = IRQ_DWMCI,
> - .flags = IORESOURCE_IRQ,
> - }
> + [0] = DEFINE_RES_MEM(EXYNOS4_PA_DWMCI, SZ_4K),
> + [1] = DEFINE_RES_IRQ(EXYNOS4_IRQ_DWMCI),
> };
>
> static struct dw_mci_board exynos4_dwci_pdata = {
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
