On 02/16/12 16:43, Heiko Stübner wrote:
Hi Kgene, Am Sonntag, 12. Februar 2012, 14:59:54 schrieb Heiko Stübner:Commit b27b072791dc (ARM: 7265/1: restart: S3C24XX: use new restart hook) introduced the new restart hook also for the S3C244x cpus, but it was only defined in the S3C2440 scope, i.e. when CPU_S3C2440 was selected. Devices using the S3C2442 like the GTA02 normally don't select this CPU which leads to compilation errors like: LD .tmp_vmlinux1 arch/arm/mach-s3c2440/built-in.o:(.arch.info.init+0x3c): undefined reference to `s3c2440_restart' make: *** [.tmp_vmlinux1] Error 1 Therefore move the s3c2440_restart function to s3c244x.c which is common to both cpus and also fix the naming to reflect this. Reported-by: Denis 'GNUtoo' Carikli<GNUtoo@xxxxxxxxxx> Signed-off-by: Heiko Stuebner<heiko@xxxxxxxxx>could you take a look at this patch and possibly pick it up as fix for the current -rcs.
Hi, Yes, looks ok to me. I will apply in v3.3-samsung-fixes-4. Thanks for fixing and testing :) Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
