On Tue, Jan 31, 2012 at 02:40:41PM +0000, Kukjin Kim wrote: > On 01/31/12 23:32, Will Deacon wrote: > > On Tue, Jan 31, 2012 at 02:21:28PM +0000, Kukjin Kim wrote: > >> On 01/31/12 23:13, Will Deacon wrote: > >>> > >>> This doesn't belong in smp.c but, more importantly, this doesn't work for > >>> multi-cluster configurations at all. Since all A15 implementations will be > >>> on new platforms, the code will be device-tree only and so we should use > >> > >> Why not? As I know, current arm kernel ARMv7 arch can support A15 > >> without device-tree. And you know, the core number should be counted by > >> L2 control register. no? > > > > I'll answer these in order: > > Hmm, let > > > > 1.) The code doesn't belong in smp.c because it's specific to the A15 > > Yes, agree. So I just commented in my patch, I'm not sure where it > should be added at. I do not think it should be added at all. And if you add it at least add it to your BSP code (not in smp.c), because it works for a single cluster A15 configuration, it does not for other A15 based systems. I think Will's comment was pretty clear about this. > > 2.) The architecture code may well support A15, but since there are no > > platforms in mainline that support A15 yet, then all new platforms will > > need to be DT-based. That means we can rely on the DT to provide this > > information. > > Well, I will submit EXYNOS5 which has two A15 cores today and I don't > know why it should be supported only with DT, EXYNOS5 DT supporting will > be submitted though. > See above. > > 3.) The L2 control register only tells you how many cores are hanging off > > that particular L2. This will be wrong for multi-cluster systems since > > it will only identify a subset of the cores. > > OK, let me check it. Check it and you will notice that it does not work for multi-cluster SMP systems. > > > >>> I believe Lorenzo posted some patches which you could look at. > >>> > >> OK, Would be better. > > > > Yes, I think it's the only way to solve this problem without adding an > > architected method for enumerating the CPU topology. > > > I'm not sure it is the only way... We are not stating that it is the only way to do it. We are saying it is the only way to do it in a generic way without relying on a per platform hook (if it exists). If it does not and we rely on this patch, we end up booting only one cluster out of the possible ones, which is awesome. I am against adding this code for the aforementioned reasons. Lorenzo -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |