On Tue, Jan 31, 2012 at 09:11:10PM +0900, Kukjin Kim wrote:
> diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
> index 57db122..be4d31d 100644
> --- a/arch/arm/kernel/smp.c
> +++ b/arch/arm/kernel/smp.c
> @@ -233,6 +233,22 @@ void __ref cpu_die(void)
> }
> #endif /* CONFIG_HOTPLUG_CPU */
>
> +/*
> + * Get the number of CPU cores from the L2 control register on A15
> + */
> +unsigned long a15_get_core_count(void)
> +{
> + unsigned long val;
> +
> + /* Read L2 control register */
> + asm volatile("mrc p15, 1, %0, c9, c0, 2" : "=r"(val));
> +
> + /* [25:24] of L2 control register means core count - 1 */
> + val = ((val >> 24) & 0x3) + 1;
> +
> + return val;
> +}
> +
This is *definitely* the wrong place for this. Do we have the reading
of the number of cores from the SCU in smp.c ? No. Do we want to litter
smp.c with each architecture revisions own way of reading this information?
No.
Keep this kind of crap out of the main smp.c file please. It contains
zero CPU and platform specifics and should stay that way.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
