On Tue, Jul 26, 2011 at 10:04:10PM +0900, Boojin Kim wrote: > Vinod Koul Wrote: > > I meant you should use proper fields for passing info, which in this > > case would be dst_maxburst for specifying destination burst sizes > I think the naming seems to make confusion. > 'Peri->burst_sz' on this code means the width of fifo in bytes of the peri. > It's same with the meaning 'xxx_addr_width'. So, I think it's proper usage. > 'peri->burst_sz' is passed to PL330 HW. PL330 HW wants to get the power of 2 > based the fifo width for it. > For example, If fifo width is 8 bytes, PL330 HW should get '3' for it. > And I will modify code to consider xxx_maxburst. IMHO from your description above, peri->burst_sz is misnamed. Please add a comment at this location to say something like: /* peri->burst_sz is the peripheral fifo width */ to explain this. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |