On Thu, May 26, 2011 at 7:54 PM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Wed, May 25, 2011 at 11:45:37PM +0530, Jassi Brar wrote: > >> I2C here is a SMDK specific requirement and even if most devices need I2C, >> selecting I2C for every EXYNOS4210 based device is not ideal. IMO it'd better >> be tied to some SMDK specific config option. > > Given that it's the audio machine driver the dependency on I2C doesn't > seem unreasonable Yup, actually I am not dead against the submitted patch... it's just that historically Samsung ASoC doesn't include I2C dependency, so why now. > - the CODEC will generally be I2C connected so I2C is > going to be required for the driver to do anything useful. ÂMight be > better to just add a dependency on the WM8994 MFD, though, which does > roughly the same thing. Should do too. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html