Kyungmin Park wrote: > > On Fri, Dec 3, 2010 at 1:22 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: > > Sylwester Nawrocki wrote: > >> > >> Added resource definitions for mipi-csis interface, naming > >> changed for consistency with s5pv310 where there are two > >> instances of the device. > >> > >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > >> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > >> --- > >> arch/arm/mach-s5pv210/include/mach/irqs.h | 2 +- > >> arch/arm/mach-s5pv210/include/mach/map.h | 4 ++++ > >> arch/arm/mach-s5pv210/include/mach/regs-clock.h | 5 +---- > >> 3 files changed, 6 insertions(+), 5 deletions(-) > >> > >> diff --git a/arch/arm/mach-s5pv210/include/mach/irqs.h b/arch/arm/mach- > >> s5pv210/include/mach/irqs.h > >> index 119b95f..8b5994c 100644 > >> --- a/arch/arm/mach-s5pv210/include/mach/irqs.h > >> +++ b/arch/arm/mach-s5pv210/include/mach/irqs.h > >> @@ -65,7 +65,7 @@ > >> #define IRQ_HSMMC0 S5P_IRQ_VIC1(26) > >> #define IRQ_HSMMC1 S5P_IRQ_VIC1(27) > >> #define IRQ_HSMMC2 S5P_IRQ_VIC1(28) > >> -#define IRQ_MIPICSI S5P_IRQ_VIC1(29) > >> +#define IRQ_MIPICSI0 S5P_IRQ_VIC1(29) > > > > Firstly don't use directly IRQ_MIPICSI0 which is used in platform device. > > Because it can be confused that there would be another MIPICSI such as > > MIPICSI1. > > In that case, just use like following. For example, > Hi, > > First respect others work. > my impression is that you forced the developers to work as you want. > > okay who summit this code? If you think name is odd, then you check it > before you submitted. > When you commit the code is okay, but other should be considered as yours. > I can't get you :-( Maybe your talking is to change the name? Why?... When submitted it, used written name, IRQ_MIPICSI in datasheet. But now, according to Sylwester's patch, used various name for it like MIPICSI, MIPICSIS and so on. So I suggested just one name in previous my comment. > > > > --- > > @@ -132,5 +132,6 @@ > > #define IRQ_LCD_FIFO IRQ_LCD0 > > #define IRQ_LCD_VSYNC IRQ_LCD1 > > #define IRQ_LCD_SYSTEM IRQ_LCD2 > > +#define IRQ_MIPI_CSIS0 IRQ_MIPICSI > > > > #endif /* ASM_ARCH_IRQS_H */ > > --- > > > > And I'm confused about the name of MIPI-CSI... > > Hmm...used MIPICSI or MIPI_CSI, sometimes MIPICSIS or MIPI_CSIS. > > > > Maybe the meaning is Camera Serial Interface Slave... > > So...how about to use just one such as "IRQ_MIPI_CSIS" and > > "S5PV210_PA_MIPI_CSIS". > > I think it's better use the common word, CSI. I can't find CSIS word > at googling. > But used it in datasheet. How about FIMC, I think, it depends on usage of datasheet. > > > > --- > > @@ -65,7 +65,7 @@ > > #define IRQ_HSMMC0 S5P_IRQ_VIC1(26) > > #define IRQ_HSMMC1 S5P_IRQ_VIC1(27) > > #define IRQ_HSMMC2 S5P_IRQ_VIC1(28) > > -#define IRQ_MIPICSI S5P_IRQ_VIC1(29) > > +#define IRQ_MIPI_CSIS S5P_IRQ_VIC1(29) > > #define IRQ_MIPIDSI S5P_IRQ_VIC1(30) > > #define IRQ_ONENAND_AUDI S5P_IRQ_VIC1(31) > > > > @@ -132,5 +132,6 @@ > > #define IRQ_LCD_FIFO IRQ_LCD0 > > #define IRQ_LCD_VSYNC IRQ_LCD1 > > #define IRQ_LCD_SYSTEM IRQ_LCD2 > > +#define IRQ_MIPI_CSIS0 IRQ_MIPI_CSIS > > In this case, I can't find any good reason since it's first used. > as s3c series used the different names compare to s5p series. it's > okay make these wrapper. > but it's new one and not used previous time. > I already commented about that. Shortly, IRQ_MIPI_CSIS0 is used as common name for S5PV210 and S5PV310 in plat-s5p. And IRQ_MIPI_CSI is used as specific name on S5PV210. So needed it. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |