Re: [PATCH 2/4] mach-s5pv310: Add resource definitions for mipi-csis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 3, 2010 at 2:34 PM, Kyungmin Park <kyungmin.park@xxxxxxxxxxx> wrote:
> On Fri, Dec 3, 2010 at 1:59 PM, Jassi Brar <jassisinghbrar@xxxxxxxxx> wrote:
>>> Sylwester Nawrocki wrote:

>>> +#define S5PV310_PA_CSIS0 Â Â Â Â Â Â (0x11880000)
>>> +#define S5PV310_PA_CSIS1 Â Â Â Â Â Â (0x11890000)
>>
>> Let us please not contain constants in brackets.
>
> I think consistency is more higher than your comment normally.
>
> if you think these, then make a cleanup first.

Bad logic. One shouldn't hold good practice at ransom because of
the past bad ones.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux