Kukjin Kim wrote: > > Kyungmin Park wrote: > > One more.. > > > And I'm confused about the name of MIPI-CSI... > > > Hmm...used MIPICSI or MIPI_CSI, sometimes MIPICSIS or MIPI_CSIS. > > > > > > Maybe the meaning is Camera Serial Interface Slave... > > > So...how about to use just one such as "IRQ_MIPI_CSIS" and > > > "S5PV210_PA_MIPI_CSIS". > > > > I think it's better use the common word, CSI. I can't find CSIS word > > at googling. > > > But used it in datasheet. How about FIMC, I think, it depends on usage of > datasheet. > However, if required, it can be changed... I meant to use written name in datasheet is better to us. > > > > > > --- > > > @@ -65,7 +65,7 @@ > > > #define IRQ_HSMMC0 S5P_IRQ_VIC1(26) > > > #define IRQ_HSMMC1 S5P_IRQ_VIC1(27) > > > #define IRQ_HSMMC2 S5P_IRQ_VIC1(28) > > > -#define IRQ_MIPICSI S5P_IRQ_VIC1(29) > > > +#define IRQ_MIPI_CSIS S5P_IRQ_VIC1(29) > > > #define IRQ_MIPIDSI S5P_IRQ_VIC1(30) > > > #define IRQ_ONENAND_AUDI S5P_IRQ_VIC1(31) > > > > > > @@ -132,5 +132,6 @@ > > > #define IRQ_LCD_FIFO IRQ_LCD0 > > > #define IRQ_LCD_VSYNC IRQ_LCD1 > > > #define IRQ_LCD_SYSTEM IRQ_LCD2 > > > +#define IRQ_MIPI_CSIS0 IRQ_MIPI_CSIS > > > > In this case, I can't find any good reason since it's first used. > > as s3c series used the different names compare to s5p series. it's > > okay make these wrapper. > > but it's new one and not used previous time. > > > I already commented about that. > Shortly, IRQ_MIPI_CSIS0 is used as common name for S5PV210 and S5PV310 in > plat-s5p. > And IRQ_MIPI_CSI is used as specific name on S5PV210. So needed it. > To use IRQ_MIPI_CSIS means just one on S5PV210. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |