On Sun, Dec 13, 2009 at 13:55 +0900, jassi brar wrote: > On Fri, Dec 11, 2009 at 6:52 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: > > This patch adds Kconfigs and Makefiles for S5P6440. > > > > Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx> > > Signed-off-by: Adityapratap Sharma <aditya.ps@xxxxxxxxxxx> > > Signed-off-by: Thomas Abraham <thomas.ab@xxxxxxxxxxx> > > Signed-off-by: Atul Dahiya <atul.dahiya@xxxxxxxxxxx> > > --- > > arch/arm/Kconfig | 14 ++++++++++++- > > arch/arm/Makefile | 2 + > > arch/arm/mach-s5p6440/Kconfig | 21 ++++++++++++++++++++ > > arch/arm/mach-s5p6440/Makefile | 19 ++++++++++++++++++ > > arch/arm/mach-s5p6440/Makefile.boot | 2 + > > arch/arm/plat-s5p/Kconfig | 36 > +++++++++++++++++++++++++++++++++++ > > arch/arm/plat-s5p/Makefile | 25 ++++++++++++++++++++++++ > > 7 files changed, 118 insertions(+), 1 deletions(-) > > create mode 100644 arch/arm/mach-s5p6440/Kconfig > > create mode 100644 arch/arm/mach-s5p6440/Makefile > > create mode 100644 arch/arm/mach-s5p6440/Makefile.boot > > create mode 100644 arch/arm/plat-s5p/Kconfig > > create mode 100644 arch/arm/plat-s5p/Makefile > > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > index 78b6060..c9cb8ee 100644 > > --- a/arch/arm/Kconfig > > +++ b/arch/arm/Kconfig > > @@ -588,6 +588,13 @@ config ARCH_S3C64XX > > help > > Samsung S3C64XX series based systems > > > > +config ARCH_S5P6440 > > + bool "Samsung S5P6440" > > + select GENERIC_GPIO > > + select HAVE_CLK > > + help > > + Samsung S5P6440 CPU based systems > > + > > config ARCH_S5PC1XX > > bool "Samsung S5PC1XX" > > select GENERIC_GPIO > > @@ -707,6 +714,7 @@ source "arch/arm/plat-samsung/Kconfig" > > source "arch/arm/plat-s3c24xx/Kconfig" > > source "arch/arm/plat-s3c64xx/Kconfig" > > source "arch/arm/plat-s3c/Kconfig" > > +source "arch/arm/plat-s5p/Kconfig" > > source "arch/arm/plat-s5pc1xx/Kconfig" > > > > if ARCH_S3C2410 > > @@ -723,6 +731,10 @@ source "arch/arm/mach-s3c6400/Kconfig" > > source "arch/arm/mach-s3c6410/Kconfig" > > endif > > > > +if ARCH_S5P6440 > > +source "arch/arm/mach-s5p6440/Kconfig" > > +endif > > + > Why does samsung support don't parse the Kconfig like other archs and > have special checks "if ARCH_xxx" ? Why not include it as the > first thing in the Kconfig just like every other mach/platform? > > I think, for 6440, the check could be put inside the Kconfig and another > patch maybe submitted to do the same for other Samsung SoCs as well. I did follow up other Samsung's SoC code style. But as you mentioned, other mach/platform differs. Hmm... I will check which one is better or right. > > source "arch/arm/plat-stmp3xxx/Kconfig" > > > > if ARCH_S5PC1XX > > @@ -1005,7 +1017,7 @@ config PREEMPT > > config HZ > > int > > default 128 if ARCH_L7200 > > - default 200 if ARCH_EBSA110 || ARCH_S3C2410 > > + default 200 if ARCH_EBSA110 || ARCH_S3C2410 || ARCH_S5P6440 > > default OMAP_32K_TIMER_HZ if ARCH_OMAP && OMAP_32K_TIMER > > default AT91_TIMER_HZ if ARCH_AT91 > > default 100 > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > > index a026565..376da2b 100644 > > --- a/arch/arm/Makefile > > +++ b/arch/arm/Makefile > > @@ -151,6 +151,7 @@ machine-$(CONFIG_ARCH_S3C2410) := > s3c2410 s3c2400 s3c2412 s3c2440 s3c2442 s3c24 > > machine-$(CONFIG_ARCH_S3C24A0) := s3c24a0 > > machine-$(CONFIG_ARCH_S3C64XX) := s3c6400 s3c6410 > > machine-$(CONFIG_ARCH_S5PC1XX) := s5pc100 > > +machine-$(CONFIG_ARCH_S5P6440) := s5p6440 > option for 6440 shud come before c100 as per alpha-numeric sort, which is > used for the list of machines. Ok, I will change it. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, System LSI Division, SAMSUNG ELECTRONICS CO., LTD. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |