On Sat, Dec 12, 2009 at 01:04 +0900, Marc Zyngier wrote:
> On Fri, 11 Dec 2009 18:55:00 +0900
> Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
>
> > +static struct s3c2410_uartcfg smdk6440_uartcfgs[] __initdata = {
> > + [0] = {
> > + .hwport = 0,
> > + .flags = 0,
> > + .ucon = S5P6440_UCON_DEFAULT,
> > + .ulcon = S5P6440_ULCON_DEFAULT,
> > + .ufcon = S5P6440_UFCON_DEFAULT,
> > + },
> > + [1] = {
> > + .hwport = 1,
> > + .flags = 0,
> > + .ucon = S5P6440_UCON_DEFAULT,
> > + .ulcon = S5P6440_ULCON_DEFAULT,
> > + .ufcon = S5P6440_UFCON_DEFAULT,
> > + },
> > + [2] = {
> > + .hwport = 2,
> > + .flags = 0,
> > + .ucon = S5P6440_UCON_DEFAULT,
> > + .ulcon = S5P6440_ULCON_DEFAULT,
> > + .ufcon = S5P6440_UFCON_DEFAULT,
> > + },
> > + [3] = {
> > + .hwport = 3,
> > + .flags = 0,
> > + .ucon = S5P6440_UCON_DEFAULT,
> > + .ulcon = S5P6440_ULCON_DEFAULT,
> > + .ufcon = S5P6440_UFCON_DEFAULT,
> > + },
> > +};
>
> Doing so means that UARTs will get the default clock (PCLK), which is
> always wrong on s5p6440. You should here set the .clock field of each
> UART, according to your specific configuration (probably PCLK_LOW).
>
> Or at least make sure it gets set to some sane default in the CPU
> support code.
Ok. As you know, my clock codes have something to change about PCLK and
PCLK_LOW. I will check this code when I fix clock codes. And change it.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
System LSI Division, SAMSUNG ELECTRONICS CO., LTD.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
