RE: [PATCH 2/7] ARM: S5P6440: CPU initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 13, 2009 at 16:48 +0900, jassi brar wrote:
> On Fri, Dec 11, 2009 at 6:54 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
> > This patch adds S5P6440 support.
> >
> > Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> > Signed-off-by: Adityapratap Sharma <aditya.ps@xxxxxxxxxxx>
> > Signed-off-by: Thomas Abraham <thomas.ab@xxxxxxxxxxx>
> > Signed-off-by: Atul Dahiya <atul.dahiya@xxxxxxxxxxx>
> > ---
> >  arch/arm/mach-s5p6440/cpu.c                      |  120
> ++++++++++++++++++++++
> >  arch/arm/mach-s5p6440/include/mach/debug-macro.S |   37 +++++++
> >  arch/arm/mach-s5p6440/include/mach/entry-macro.S |   42 ++++++++
> >  arch/arm/mach-s5p6440/include/mach/gpio-core.h   |   19 ++++
> >  arch/arm/mach-s5p6440/include/mach/gpio.h        |   79 ++++++++++++++
> >  arch/arm/mach-s5p6440/include/mach/hardware.h    |   18 ++++
> >  arch/arm/mach-s5p6440/include/mach/idle.h        |   23 ++++
> >  arch/arm/mach-s5p6440/include/mach/map.h         |  100
> ++++++++++++++++++
> >  arch/arm/mach-s5p6440/include/mach/memory.h      |   22 ++++
> >  arch/arm/mach-s5p6440/include/mach/system.h      |   40 +++++++
> >  arch/arm/mach-s5p6440/include/mach/uncompress.h  |   24 +++++
> >  arch/arm/plat-s3c/include/plat/cpu.h             |    2 +
> >  arch/arm/plat-s5p/cpu.c                          |   88 ++++++++++++++++
> >  arch/arm/plat-s5p/include/plat/s5p6440.h         |   33 ++++++
> >  arch/arm/plat-s5p/s5p6440-init.c                 |   23 ++++
> >  arch/arm/plat-s5p/setup-i2c0.c                   |   23 ++++
> >  16 files changed, 693 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/arm/mach-s5p6440/cpu.c
> >  create mode 100644 arch/arm/mach-s5p6440/include/mach/debug-macro.S
> >  create mode 100644 arch/arm/mach-s5p6440/include/mach/entry-macro.S
> >  create mode 100644 arch/arm/mach-s5p6440/include/mach/gpio-core.h
> >  create mode 100644 arch/arm/mach-s5p6440/include/mach/gpio.h
> >  create mode 100644 arch/arm/mach-s5p6440/include/mach/hardware.h
> >  create mode 100644 arch/arm/mach-s5p6440/include/mach/idle.h
> >  create mode 100644 arch/arm/mach-s5p6440/include/mach/map.h
> >  create mode 100644 arch/arm/mach-s5p6440/include/mach/memory.h
> >  create mode 100644 arch/arm/mach-s5p6440/include/mach/system.h
> >  create mode 100644 arch/arm/mach-s5p6440/include/mach/uncompress.h
> >  create mode 100644 arch/arm/plat-s5p/cpu.c
> >  create mode 100644 arch/arm/plat-s5p/include/plat/s5p6440.h
> >  create mode 100644 arch/arm/plat-s5p/s5p6440-init.c
> >  create mode 100644 arch/arm/plat-s5p/setup-i2c0.c

(snip)

> Perhaps arch/arm/plat-s5p/Makefile shud be in this patch, rather than
> the first one.
> Otherwise, you enable compilation before having the code.
> 
> Also, we need to look at the order of defining and using functions in
> patches in wrong order.
> Though, it wud be okay if we don't consider patch atomicity.
Ok, as I already reply another posting, I couldn't consider patch atomicity. And all(almost?) my patches need so that can support s5p6440. Of course they can be modified.


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
System LSI Division, SAMSUNG ELECTRONICS CO., LTD.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux